Re: [PATCH 3/3] selftests/efivarfs: Add create-read test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-01-29 at 07:40 +0900, Jeremy Kerr wrote:
> Hi all,
> 
> >> Empty variable never exists in nvram per spec. Userspace doesn't need an
> >> extra
> >> EIO to figure out this known fact. In the meantime, user would wonder if
> >> something else has gone wrong? Returning zero for reading an empty file can
> >> reserve EIO for something more informational.
> >
> > Perhaps it's not unreasonable to expect users to understand that
> > zero-length files don't have a corresponding EFI variable, and that the
> > file won't persist across a reboot.
> >
> > Jeremy, thoughts?
> 
> I think that EOF would be better; it's not really an "error" condition, 
> just that no data has been given yet.

Works for me.

> I'd be happy to change this check to suit.

That would be great, thank you.

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux