On Tue, 2013-01-29 at 07:45 +0900, Jeremy Kerr wrote: > Yes, the intention is to bump the refcount any time we store the struct > efivars_entry somewhere it might be referenced later (ie, in > inode->i_private in this case). I'll add the ref when we create the > inodes too. > > One of my concerns with the current patch is using the empty list as an > indicator whether the variable is present in firmware. Alternatively, we > could do this with a new bool 'deleted' in the strut efivars_entry, > which is set on unlink(). Any preferences? I think using presence on the efivar list to indicate that a variable exists in the firmware is a nice and simple solution. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html