Re: [PATCH 3/3] selftests/efivarfs: Add create-read test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/28/2013 08:37 PM, Matt Fleming wrote:
I was the one who originally suggested using EIO for reading a variable
that hasn't hit the backing store, mainly because it simplified the
EFI_NOT_FOUND logic, and I felt that reading from a non-existent
variable should be an error condition. But I can see the case for
returning zero instead.

I agree translating EFI_NOT_FOUND to EIO is generally a good choice.
But in the special case of an uncommitted empty file, kernel can avoid
reading the expectedly non-existent variable and instead return
EOF directly.

Yes, empty files are uncommitted and will go away after reboot anyway,
regardless of EIO or not. Users have to know this.
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux