On Fri, Jan 25, 2013 at 08:45:37AM +0000, Matt Fleming wrote: > Matthew, what guarantees do we have that the memory we've allocated for > the PCI ROMs isn't going to be reused? I suspect what's needed is for > parse_setup_data() to reserve the SETUP_PCI regions, just like you would > for any other key data structure. Yeah, I think that originally I had a copy and then failed to update this to handle just re-using the original allocation. > It's the kernel's responsibility to protect any EFI_LOADER_DATA regions > that it needs, we shouldn't have to trick ourselves by using the > EFI_RUNTIME_SERVICES_DATA pool for allocations. I guess the concern is that non-EFI systems may end up passing SETUP_PCI? EFI_RUNTIME_DATA would solve one case without handling that, so doing it in the data parsing code probably does make sense. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
