On Wed, 2012-12-26 at 17:24 +0800, Lingzhu Xiang wrote: > On 10/26/2012 03:52 PM, Matt Fleming wrote: > > From: Matt Fleming<matt.fleming@xxxxxxxxx> > > > > Seeing "+ 4" littered throughout the functions gets a bit > > confusing. Use "sizeof(attributes)" which clearly explains what > > quantity we're adding. > > > > Acked-by: Jeremy Kerr<jeremy.kerr@xxxxxxxxxxxxx> > > Signed-off-by: Matt Fleming<matt.fleming@xxxxxxxxx> > > Looks like one +4 got left behind, in efivarfs_fill_super > > i_size_write(inode, size+4); Yep, so it does. I'll cook something up, thanks. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html