Re: [PATCH 01/20] efi: Add support for a UEFI variable filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-12-21 at 13:54 +0800, Lingzhu Xiang wrote:
> On 10/26/2012 03:51 PM, Matt Fleming wrote:
> > +static int efivarfs_unlink(struct inode *dir, struct dentry *dentry)
> > +{
> > +	struct efivar_entry *var = dentry->d_inode->i_private;
> > +	struct efivars *efivars = var->efivars;
> > +	efi_status_t status;
> > +
> > +	spin_lock(&efivars->lock);
> > +
> > +	status = efivars->ops->set_variable(var->var.VariableName,
> > +					&var->var.VendorGuid,
> > +					    0, 0, NULL);
> > +
> > +	if (status == EFI_SUCCESS || status == EFI_NOT_FOUND) {
> > +		list_del(&var->list);
> > +		spin_unlock(&efivars->lock);
> > +		efivar_unregister(var);
> > +		drop_nlink(dir);
> 
> This should be  drop_nlink(dentry->d_inode);

Yep, this looks right. Care to send a proper patch with a Signed-off-by?

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux