On Wed, Oct 31, 2012 at 9:13 AM, Kay Sievers <kay@xxxxxxxx> wrote: > On Wed, Oct 31, 2012 at 2:04 PM, Colin Walters <walters@xxxxxxxxxx> wrote: >> On Mon, 2012-10-29 at 10:21 +0800, joeyli wrote: >> >>> I tested this patch on my UEFI notebook with latest EFI kernel git tree, >>> the efivarfs mounted normally after system boot and I can delete/add EFI >>> variable through /sys/firmware/efi/efivars. >> >> This causes systemd to output a warning if the kernel doesn't have an >> efivars module. I suppose to do this kind of thing "right" we'd >> have to conditionalize the module loads on available kernel version they >> first appeared in? > > We should probably suppress the warning that the module cannot be > loaded. And then maybe make the mount conditional, depending on the > existence of the target directory. > > This should make all that only trigger when the kernel module is > available or it is compiled-in (libkmod tells the same), and do > nothing on older kernel, kernels without the filesysystem, or > platforms without EFI. Yes to all of that. For those wanting a distro kernel to play with that has this support, we've included efivarfs in Fedora rawhide and soon in F18. josh -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html