Re: [PATCH 03/20] efi: add efivars kobject to efi sysfs folder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Oct 2012 08:51:46 +0100
Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:

> From: "Lee, Chun-Yi" <joeyli.kernel@xxxxxxxxx>
> 
> UEFI variable filesystem need a new mount point, so this patch add
> efivars kobject to efi_kobj for create a /sys/firmware/efi/efivars
> folder.
> 
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxx>
> Signed-off-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> ---
>  drivers/firmware/efivars.c | 11 +++++++++++
>  include/linux/efi.h        |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index 6d43bbd..4b12a8fd 100644
> --- a/drivers/firmware/efivars.c
> +++ b/drivers/firmware/efivars.c
> @@ -1527,6 +1527,7 @@ void unregister_efivars(struct efivars *efivars)
>  		sysfs_remove_bin_file(&efivars->kset->kobj, efivars->del_var);
>  	kfree(efivars->new_var);
>  	kfree(efivars->del_var);
> +	kobject_put(efivars->kobject);

This makes no sense - you already always unregister the kset in
register_efivars ?
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux