> > On the other hand, patch 5/5 changes the format by adding sequence counter. > > But efi_pstore_read is modied to work correctly in it. > > > > dump-type0-1-1-1351113059-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 > > > > Variable Name: dump-type0-1-1-1351113059 > > GUID: cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 > > > > If I need to elaborate more, please feel free to ask me:) I'm not sure > > if I understand your question completely. > > In this case, I think efi_pstore_read in patch 5/5 should probably fall-back to trying to do a sscanf(...) == 3 if the sscanf(...) == 4 test fails > so that dumps for older dumps from previous kernels are still visible to users, no? They can perhaps get a default count of 0? > efi_pstore_erase would have to be updated to understand this as well. OK. I understand your concern. I will update my patch to work with an old format too. In addition to efi_pstore_read(), efi_pstore_erase should be modified. Anyway, I will post a patch v3 later. Thank you for reviewing. Seiji -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
