Re: [PATCH] efi: Clarify GUID length calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-10-19 at 09:54 +0100, Matt Fleming wrote:
> (Cc'ing some other folks that might be interested)
> 
> On Fri, 2012-10-19 at 15:16 +0800, Jeremy Kerr wrote:
> > At present, the handling of GUIDs in efivar file names isn't consistent.
> > We use GUID_LEN in some places, and 38 in others (GUID_LEN plus
> > separator), and implicitly use the presence of the trailing NUL.
> > 
> > This change removes the trailing NUL from GUID_LEN, so that we're
> > explicitly adding it when required. We also replace magic numbers
> > with GUID_LEN, and clarify the comments where appropriate.
> > 
> > We also fix the allocation size in efivar_create_sysfs_entry, where
> > we're allocating one byte too much, due to counting the trailing NUL
> > twice - once when calculating short_name_size, and once in the kzalloc.
> > 
> > Signed-off-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>

Applied, thanks!

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux