I tried out Christophe Thommeret's Kaffeine s2api changes, and ran
into a problem. The u.vsb.modulation field was always zero, resulting
in lgdt330x indicating failures.
I traced through the new dvb_frontend code and it appears that this
field is set when we consider the delivery system to be "legacy".
The following patch causes the s2api to start working with ATSC
devices. I'm not 100% sure this is the *right* fix, so I am
soliciting feedback on whether this was just an oversight.
I ran into this with both lgdt3303 and the s5h1411 based devices (so
it doesn't appear specific to any particular atsc demod), so unless
I'm crazy it seems like ATSC tuning through s2api is 100% broken.
Regards,
Devin
--
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
s2api - ATSC should be considered a legacy delivery system
From: Devin Heitmueller <devin.heitmueller@xxxxxxxxx>
ATSC should be considered a legacy delivery system, or else fields such as
p->u.vsb.modulation do not get populated (resulting in set_frontend failures)
Signed-off-by: Devin Heitmueller <devin.heitmueller@xxxxxxxxx>
diff -r 46604f47fca1 linux/drivers/media/dvb/dvb-core/dvb_frontend.c
--- a/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Fri Nov 07 15:24:18 2008 -0200
+++ b/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Sun Nov 09 21:04:05 2008 -0500
@@ -1064,7 +1064,8 @@
int is_legacy_delivery_system(fe_delivery_system_t s)
{
if((s == SYS_UNDEFINED) || (s == SYS_DVBC_ANNEX_AC) ||
- (s == SYS_DVBC_ANNEX_B) || (s == SYS_DVBT) || (s == SYS_DVBS))
+ (s == SYS_DVBC_ANNEX_B) || (s == SYS_DVBT) || (s == SYS_DVBS) ||
+ (s == SYS_ATSC))
return 1;
return 0;
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
