Re: [PATCH]Correct TT S2-3200 remote support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hudo kkow wrote:
> Patch corrects missing support for some TT S2-3200 remotes.
>
> Signed-off-by:Hudo KKow <hudokkow AT gmail.com>
>
> Thanks to Ales Jurik and Ville-Pekka Vainio for the feedback and the
> suggestions.
>
> Read it at http://www.linuxtv.org/pipermail/vdr/2008-November/018248.html

Hi,

It seems your patch wasn't quite correct, you forgot to remove 0x1012 from the 
previous set of cases and at least my editors show that you used spaces to 
indent 0x1012 when the file is indented with tabs.

So here's my attempt at fixing those two issues and an improved description. 
If it seems ok to you, could you please add your Signed-off-by as a reply? 
I'm sending the patch as an attachment since I'm afraid KMail might mangle 
the whitespace otherwise.

FYI, the TT-DVB-T 1500 entry at 
<http://linuxtv.org/wiki/index.php/DVB-T_PCI_Cards#TechnoTrend> instructs 
loading budget_ci with rc5_device=255. After applying this patch it shouldn't 
be necessary to set the rc5_device parameter anymore when loading the module.


Use the TT 1500 IR keymap for the TT T-1500 and the TT S2-3200

The Technotrend T-1500 and S2-3200 have been sold with the same remote 
controllers as the Technotrend C/S-1500. This patch loads the Technotrend 
1500 keymap for those two devices (subsystem ids 0x1012 and 0x1019) as well.

Signed-off-by: Ville-Pekka Vainio <vpivaini@xxxxxxxxxxxxxx>


-- 
Ville-Pekka Vainio
diff -r d3886881a99b linux/drivers/media/dvb/ttpci/budget-ci.c
--- a/linux/drivers/media/dvb/ttpci/budget-ci.c	Thu Oct 30 03:51:46 2008 +0000
+++ b/linux/drivers/media/dvb/ttpci/budget-ci.c	Wed Nov 05 23:07:33 2008 +0200
@@ -230,7 +230,6 @@
 	case 0x100c:
 	case 0x100f:
 	case 0x1011:
-	case 0x1012:
 		/* The hauppauge keymap is a superset of these remotes */
 		ir_input_init(input_dev, &budget_ci->ir.state,
 			      IR_TYPE_RC5, ir_codes_hauppauge_new);
@@ -241,7 +240,9 @@
 			budget_ci->ir.rc5_device = rc5_device;
 		break;
 	case 0x1010:
+	case 0x1012:
 	case 0x1017:
+	case 0x1019:
 	case 0x101a:
 		/* for the Technotrend 1500 bundled remote */
 		ir_input_init(input_dev, &budget_ci->ir.state,
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux