Thanks for the hints.
I made a driver update yesterday for kernel 2.6.24 using the last v4l tree I got:
v4l-dvb-2daeefda69fe, so probably that will be much more closer to the actual tree.
- Is there any way to submit it for review?
About your hints:
- you mean that static variables will be an issue.
Could then be better to include those variables in dvb_usb_device_properties?
- Yes, the register increment has no use. I can remove it away.
- I also got feedback that the debug information is not handled correctly in the driver.
Could you advice on that one?
I am really no expert, I have just been following the examples.
But since it is working, it would be great if people could use the driver.
Juan
I made a driver update yesterday for kernel 2.6.24 using the last v4l tree I got:
v4l-dvb-2daeefda69fe, so probably that will be much more closer to the actual tree.
- Is there any way to submit it for review?
About your hints:
- you mean that static variables will be an issue.
Could then be better to include those variables in dvb_usb_device_properties?
- Yes, the register increment has no use. I can remove it away.
- I also got feedback that the debug information is not handled correctly in the driver.
Could you advice on that one?
I am really no expert, I have just been following the examples.
But since it is working, it would be great if people could use the driver.
Juan
----- Mensaje original ----
De: Aidan Thornton <makosoft@xxxxxxxxxxxxxx>
Para: Juan Antonio Garcia <juanantonio_garcia_01@xxxxxxxx>
CC: Markus Rechberger <mrechberger@xxxxxxxxx>; Jakob Steidl <j.steidl@xxxxxxxxx>; linux-dvb@xxxxxxxxxxx
Enviado: viernes, 2 de mayo, 2008 12:24:07
Asunto: Re: [linux-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e
On Thu, May 1, 2008 at 8:58 PM, Markus Rechberger <mrechberger@xxxxxxxxx> wrote:
> Hi,
>
>
> On 5/1/08, Juan Antonio Garcia <juanantonio_garcia_01@xxxxxxxx> wrote:
> >
> > Hi,
> >
> > I updated the driver for being supported in kernel 2.6.24 (Ubuntu 8.04).
> >
> > I am distributing the update thought the Ubuntu forums, but it would be
> > better to distribute it to more users. So Linux has more HW supported.
> >
> > What it should be done so it is included in the v4l tree?
> >
>
> I forwarded the mail to the linux-dvb ML.
>
> > Now the driver supports 2 devices:
> >
> > - Pinnacle PCTV 200e
> > - Pinnacle PCTV 60e
> >
> > The driver wiki is:
> >
> > http://www.linuxtv.org/wiki/index.php/Pinnacle_PCTV_200e
> >
>
> Markus
Hi,
This driver seems like it should be trivial to get working on
linux-dvb, which is where you want it - the tree you've based it on
isn't much longer for this world. (I don't think any of the code
you're using has changed significantly between Markus' branch and the
main one). It needs some cleanup, though. At a glance:
- Don't use C++-style comments (the single-line // ones)
- The whole "addr == pctv200e_mt2060_config.i2c_address" part looks
iffy; I think you should remove this and use i2c_gate_ctrl instead.
Unfortunately, I'm not sure this'll work currently, since mt2060
doesn't appear to support it.
- ctrl_msg_last_device/ctrl_msg_last_operation must go - they won't
work right if you use multiple devices of this type. The code in the
"if (ctrl_msg_last_device == 0)" section can probably go elsewhere,
but I'm not sure where
- Why are you incrementing the register value in pctv200e_ctrl_msg?
The linuxtv developers will probably be able to give you more advice.
Aidan
De: Aidan Thornton <makosoft@xxxxxxxxxxxxxx>
Para: Juan Antonio Garcia <juanantonio_garcia_01@xxxxxxxx>
CC: Markus Rechberger <mrechberger@xxxxxxxxx>; Jakob Steidl <j.steidl@xxxxxxxxx>; linux-dvb@xxxxxxxxxxx
Enviado: viernes, 2 de mayo, 2008 12:24:07
Asunto: Re: [linux-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e
On Thu, May 1, 2008 at 8:58 PM, Markus Rechberger <mrechberger@xxxxxxxxx> wrote:
> Hi,
>
>
> On 5/1/08, Juan Antonio Garcia <juanantonio_garcia_01@xxxxxxxx> wrote:
> >
> > Hi,
> >
> > I updated the driver for being supported in kernel 2.6.24 (Ubuntu 8.04).
> >
> > I am distributing the update thought the Ubuntu forums, but it would be
> > better to distribute it to more users. So Linux has more HW supported.
> >
> > What it should be done so it is included in the v4l tree?
> >
>
> I forwarded the mail to the linux-dvb ML.
>
> > Now the driver supports 2 devices:
> >
> > - Pinnacle PCTV 200e
> > - Pinnacle PCTV 60e
> >
> > The driver wiki is:
> >
> > http://www.linuxtv.org/wiki/index.php/Pinnacle_PCTV_200e
> >
>
> Markus
Hi,
This driver seems like it should be trivial to get working on
linux-dvb, which is where you want it - the tree you've based it on
isn't much longer for this world. (I don't think any of the code
you're using has changed significantly between Markus' branch and the
main one). It needs some cleanup, though. At a glance:
- Don't use C++-style comments (the single-line // ones)
- The whole "addr == pctv200e_mt2060_config.i2c_address" part looks
iffy; I think you should remove this and use i2c_gate_ctrl instead.
Unfortunately, I'm not sure this'll work currently, since mt2060
doesn't appear to support it.
- ctrl_msg_last_device/ctrl_msg_last_operation must go - they won't
work right if you use multiple devices of this type. The code in the
"if (ctrl_msg_last_device == 0)" section can probably go elsewhere,
but I'm not sure where
- Why are you incrementing the register value in pctv200e_ctrl_msg?
The linuxtv developers will probably be able to give you more advice.
Aidan
Yahoo! Solidario.
Intercambia los objetos que ya no necesitas y ayuda a mantener un entorno más ecológico.
_______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
