Re: PATCH Pinnacle 320cx Terratec Cinergy HT USB XE - Draft 2

["Albert Comerma" <albert.comerma@xxxxxxxxx>]

Perfect!! it seems great, now I will check it (sorry, I was very busy last two days). I also will add support for Felix's card and the two cards I have pending (just add device id and small modifications), so it will be easier for patrick to add the different patches to the current source. Just one comment, how you generated the patch? because mauro suggested it's better to use hg diff. In a minutes I will send the modified patch (I hope it will be the last version).

Albert

2008/3/21, Hans-Frieder Vogt <hfvogt@xxxxxxx>:

Hi Albert,

I have slightly changed the stk7700ph_frontend_attach GPIO sequence to be in line with the Windows behaviour and also add
the demod-value in stk7700ph_xc3028_ctrl, to make the driver load the right SCODE file (which seems to have no effect,
though). Also, I removed the unused and unneeded xc3028_bw_config_12mhz structure.
In addition, I followed Mauro's request for coding style changes and also add some more kernel style changes that
checkpatch highlighted (I only introduced changes where they seemed sensible, there are many, many other
areas in the file dib0700_devices.c where it does not follow the strict coding guidelines as well).

Can you please confirm that I included your changes for the Pinnacle 320cx correctly and perhaps also add a signoff-line?
Thanks very much.

Hans-Frieder

--

--
Hans-Frieder Vogt                 e-mail: hfvogt <at> gmx .dot. net

_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb