Re: saa7134-dvb: add missing dvb_attach call (for tda10046_attach)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Mauro

Matthias Schwarzott schrieb:
> On Samstag, 26. Januar 2008, Hartmut Hackmann wrote:
>> Hi,
>>
>> Matthias Schwarzott schrieb:
>>> Hi there!
>>> The attached small patch adds a missing dvb_attach wrapping around
>>> tda10046_attach.
>>> So it removes the hard dependency of saa7134-dvb on tda1004x module.
>>>
>>> I have only tested compiling as I don not have the hardware.
>>>
>>> Greetings
>>> Matthias
>> I don't have this hardware either but your patch is right.
>> Can you please resend it with your signature like
>>
>> Signed-off-by: Hartmut Hackmann <hartmut.hackmann@xxxxxxxxxxx>
>>
>> (of corse with your name and e-mail address)
>>
>> Please do this soon otherwise it will not make it into the next
>> kernel release.
>>
> Here you have it :)
> 
> Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx>
> 
> Regards
> Matthias
> 
> 
Can you please integrate this bugfix?
I think it should go into the next kernel.

Best regards
  Hartmut
saa7134-dvb: add missing dvb_attach around tda10046_attach

This patch adds a possibly missing dvb_attach for tda10046_attach.
This removes the hard dependency of saa7134-dvb on tda1004x module.

Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx>
Index: v4l-dvb/linux/drivers/media/video/saa7134/saa7134-dvb.c
===================================================================
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-dvb.c
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-dvb.c
@@ -1007,8 +1007,9 @@ static int dvb_init(struct saa7134_dev *
 		}
 		break;
 	case SAA7134_BOARD_ASUS_EUROPA2_HYBRID:
-		dev->dvb.frontend = tda10046_attach(&medion_cardbus,
-						    &dev->i2c_adap);
+		dev->dvb.frontend = dvb_attach(tda10046_attach,
+					       &medion_cardbus,
+					       &dev->i2c_adap);
 		if (dev->dvb.frontend) {
 			dev->original_demod_sleep = dev->dvb.frontend->ops.sleep;
 			dev->dvb.frontend->ops.sleep = philips_europa_demod_sleep;
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux