On Donnerstag, 20. Dezember 2007, Andreas Oberritter wrote: > Matthias Schwarzott wrote: > > Changing mt312 driver today. > > > > The first patch improves codingstyle - I did fix almost all things > > checkpatch lists. > > I did not change if ((ret = func(a)) < 0) { > > Btw. what do you think about this coding pattern? Should that also be changed to (as checkpatch suggests): ret = func(a); if (ret < 0) { As the first form seems to be used in very many lines and different drivers. Matthias -- Matthias Schwarzott (zzam) _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb