Re : [Patch] saa7146: 'wait_for_debi_done' fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/09/2007 06:15:14 PM, Oliver Endriss wrote:
@all users of saa7146-based cards

(drivers: dvb-ttpci, budget, budget-ci, budget-av)

Please test whether the attached patch has any negative effects.

Two fixes for the 'saa7146_wait_for_debi_done' code:
(a) Timeout did not work when the routine was called with interrupts
    disabled.
(b) Reduce PCI I/O load caused by saa7146_wait_for_debi_done.
    Seems to be very important on fast machines!

Based on a patch posted by e9hack@vdr-portal.

If nobody complains I will commit this patch next week.


A bit more info found in dmesg for the oops I experienced (see my other post):

[   51.290819] saa7146: register extension 'budget_ci dvb'.
[ 51.290909] ACPI: PCI Interrupt 0000:00:0b.0[A] -> GSI 19 (level, low) -> IRQ 20 [ 51.290970] saa7146: found saa7146 @ mem de9e6000 (revision 1, irq 20) (0x13c2,0x1017).
[   51.290986] saa7146 (0): dma buffer size 192512
[   51.290990] DVB: registering new adapter (TT-Budget/S-1500 PCI)
[   51.312152] pci_hotplug: PCI Hot Plug PCI Core version: 0.5
[   51.327557] adapter has MAC addr = 00:d0:5c:24:90:ae
[ 51.328094] input: Budget-CI dvb ir receiver saa7146 (0) as /class/input/input2
[   51.328273] budget_ci: CI interface initialised
[   51.731621] DVB: registering frontend 0 (ST STV0299 DVB-S)...
[ 51.731928] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
[   51.732046] agpgart: Detected VIA KM400/KM400A chipset
[   51.743562] agpgart: AGP aperture is 128M @ 0xd0000000
[   52.205128] input: PC Speaker as /class/input/input3
[ 52.405086] SCSI device sda: 976773168 512-byte hdwr sectors (500108 MB)
[   52.405799] sda: Write Protect is off
[   52.405803] sda: Mode Sense: 00 00 00 00
[   52.405807] sda: assuming drive cache: write through
[ 52.407475] SCSI device sda: 976773168 512-byte hdwr sectors (500108 MB)
[   52.408332] sda: Write Protect is off
[   52.408338] sda: Mode Sense: 00 00 00 00
[   52.408342] sda: assuming drive cache: write through
[   52.408349]  sda: sda1 sda2 sda3
[   52.409553] sd 2:0:0:0: Attached scsi disk sda
[   52.425436] sd 2:0:0:0: Attached scsi generic sg0 type 0
[   52.484168] parport: PnPBIOS parport detected.
[   52.484222] parport0: PC-style at 0x378, irq 7 [PCSPP,TRISTATE]
[   52.949054] input: PS/2 Generic Mouse as /class/input/input4
[   53.355399] fuse init (API version 7.8)
[   53.405095] lp0: using parport0 (interrupt-driven).
[   53.431760] Non-volatile memory driver v1.2
[ 53.483040] Adding 465844k swap on /dev/disk/by-uuid/bbf7a335-5f51-4e04-9431-c88750cc28df. Priority:-1 extents:1 across:465844k
[   53.835641] NET: Registered protocol family 10
[   53.835809] lo: Disabled Privacy Extensions
[   54.021483] kjournald starting.  Commit interval 5 seconds
[ 54.021501] EXT3-fs warning: maximal mount count reached, running e2fsck is recommended
[   54.022025] EXT3 FS on sda2, internal journal
[   54.022034] EXT3-fs: mounted filesystem with ordered data mode.
[   54.036803] kjournald starting.  Commit interval 5 seconds
[ 54.036822] EXT3-fs warning: maximal mount count reached, running e2fsck is recommended
[   54.037503] EXT3 FS on sda3, internal journal
[   54.037511] EXT3-fs: mounted filesystem with ordered data mode.
[ 54.108785] FAT: Unrecognized mount option "codepage=cp437" or missing value
[   61.450463] input: Power Button (FF) as /class/input/input5
[   61.457613] ACPI: Power Button (FF) [PWRF]
[   61.510633] input: Power Button (CM) as /class/input/input6
[   61.517678] ACPI: Power Button (CM) [PWRB]
[   61.566780] Using specific hotkey driver
[   61.633016] No dock devices found.
[   61.720679] ibm_acpi: ec object not found
[   61.987071] pcc_acpi: loading...
[   63.838178] eth0: no IPv6 routers present
[   69.482859] [drm] Initialized drm 1.1.0 20060810
[ 69.498642] ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level, low) -> IRQ 21
[   69.503944] [drm] Initialized via 2.11.0 20061227 on minor 0
[ 69.539842] agpgart: Found an AGP 3.5 compliant device at 0000:00:00.0.
[   69.540270] agpgart: Device is in legacy mode, falling back to 2.x
[ 69.540508] agpgart: Putting AGP V2 device at 0000:00:00.0 into 4x mode [ 69.540807] agpgart: Putting AGP V2 device at 0000:01:00.0 into 4x mode
[   70.601959] ppdev: user-space parallel port driver
[   82.122318] eth0: no IPv6 routers present
[   85.813694] Installing knfsd (copyright (C) 1996 okir@xxxxxxxxxxxx).
[ 86.090435] NFSD: Using /var/lib/nfs/v4recovery as the NFSv4 state recovery directory
[   86.106271] NFSD: starting 90-second grace period
[   86.752274] dvb_ca adapter 0: DVB CAM did not respond :(
[ 87.809189] BUG: unable to handle kernel NULL pointer dereference at virtual address 00000002
[   87.809203]  printing eip:
[   87.809205] dea1c262
[   87.809207] *pde = 00000000
[   87.809212] Oops: 0000 [#1]
[   87.809214] SMP
[ 87.809218] Modules linked in: binfmt_misc nfsd exportfs nfs lockd sunrpc ppdev via drm cpufreq_userspace cpufreq_stats cpufreq_powersave cpufreq_ondemand freq_table cpufreq_conservative tc1100_wmi pcc_acpi dev_acpi sony_acpi video sbs i2c_ec dock button battery container ac asus_acpi backlight vfat fat ext3 jbd ipv6 nvram lp fuse snd_mpu401 snd_mpu401_uart snd_seq_dummy snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq snd_timer snd_seq_device snd analog gameport soundcore parport_pc sg sd_mod psmouse parport pcspkr serio_raw lnbp21 i2c_viapro stv0299 via_agp shpchp pci_hotplug budget_ci budget_core dvb_core agpgart saa7146 ttpci_eeprom ir_common i2c_core af_packet evdev tsdev ext2 mbcache ide_cd cdrom ide_disk ata_generic usb_storage libusual 8139too via82cxxx floppy ohci1394 ieee1394 8139cp mii ehci_hcd uhci_hcd usbcore generic sata_via libata scsi_mod thermal processor fan fbcon tileblit font bitblit softcursor vesafb capability commoncap
[   87.809305] CPU:    0
[   87.809306] EIP:    0060:[<dea1c262>]    Not tainted VLI
[   87.809308] EFLAGS: 00010292   (2.6.20-16-generic #2)
[   87.809327] EIP is at i2c_transfer+0x22/0x60 [i2c_core]
[ 87.809331] eax: 00000002 ebx: ffffffda ecx: 00000001 edx: cce07f04 [ 87.809335] esi: d7c51804 edi: d5d8cb40 ebp: 00000001 esp: cce07eec
[   87.809338] ds: 007b   es: 007b   ss: 0068
[ 87.809342] Process kdvb-fe-0 (pid: 5686, ti=cce06000 task=ccd5e580 task.ti=cce06000) [ 87.809345] Stack: cce07f04 d7c51c08 d7c51804 d5d8cb40 d7c51c00 dea24798 00000061 00000004 [ 87.809353] cce07f10 e084e83a d7c51c08 00000001 00000001 dea04cef c13c4b40 00000000 [ 87.809361] d7c51804 d7c51c08 00000003 d7c51800 d7c51c08 00000001 00000002 dea3f190
[   87.809368] Call Trace:
[ 87.809377] [<dea24798>] alps_bsbe1_tuner_set_params+0xa8/0xd0 [budget_ci]
[   87.809396]  [<dea04cef>] stv0299_set_frontend+0x7f/0x250 [stv0299]
[ 87.809414] [<dea3f190>] dvb_frontend_swzigzag_autotune+0xf0/0x1e0 [dvb_core]
[   87.809444]  [<c011e11f>] __wake_up_locked+0x1f/0x30
[   87.809462]  [<c02ee740>] __down_interruptible+0xf0/0x120
[ 87.809479] [<dea3f99d>] dvb_frontend_swzigzag+0x1fd/0x250 [dvb_core]
[   87.809496]  [<dea40b95>] dvb_frontend_thread+0x225/0x2f0 [dvb_core]
[   87.809514]  [<c013ae00>] autoremove_wake_function+0x0/0x50
[   87.809529]  [<dea40970>] dvb_frontend_thread+0x0/0x2f0 [dvb_core]
[   87.809543]  [<c013ac4a>] kthread+0xba/0xf0
[   87.809550]  [<c013ab90>] kthread+0x0/0xf0
[   87.809557]  [<c01044c7>] kernel_thread_helper+0x7/0x10
[   87.809569]  =======================
[ 87.809571] Code: 23 70 e1 8d b6 00 00 00 00 83 ec 14 89 5c 24 04 bb da ff ff ff 89 7c 24 0c 89 c7 89 6c 24 10 89 cd 89 74 24 08 89 14 24 8b 40 0c <8b> 00 85 c0 74 1f 8d 77 20 89 f0 e8 4e 18 8d e1 8b 5f 0c 89 e9 [ 87.809602] EIP: [<dea1c262>] i2c_transfer+0x22/0x60 [i2c_core] SS:ESP 0068:cce07eec
[   87.809612]





___________________________________________________________________________
Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
http://fr.mail.yahoo.com


_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux