Hello,
I've noticed that the tda1004x driver has code that appears to support
the use of HIERARCHY_AUTO, but it does not set FE_CAN_HIERARCHY_AUTO. In
particular, at around line 720 of tda1004x.c (in tda1004x_set_fe), we
have the following code:
// Set standard params.. or put them to auto
if ((fe_params->u.ofdm.code_rate_HP == FEC_AUTO) ||
(fe_params->u.ofdm.code_rate_LP == FEC_AUTO) ||
(fe_params->u.ofdm.constellation == QAM_AUTO) ||
(fe_params->u.ofdm.hierarchy_information == HIERARCHY_AUTO)) {
The attached patch (compile-tested) sets FE_CAN_HIERARCHY_AUTO in the
tda1004x driver.
Signed-off-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx>
---
I have no datasheet for the tda10046, so I don't know whether the code
is right, or the caps setting was right. I'm assuming the caps setting
is wrong, since the driver works with HIERARCHY_AUTO and has code to
support it; however, none of the muxes I can receive use hierarchical
coding.
--
Simon Farnsworth
diff -r 25f05d3a84f5 linux/drivers/media/dvb/frontends/tda1004x.c
--- a/linux/drivers/media/dvb/frontends/tda1004x.c Thu Aug 30 15:20:42 2007 +0300
+++ b/linux/drivers/media/dvb/frontends/tda1004x.c Tue Sep 18 10:08:11 2007 +0100
@@ -1282,6 +1282,7 @@ static struct dvb_frontend_ops tda10046_
FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO |
FE_CAN_QPSK | FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
+ FE_CAN_HIERARCHY_AUTO |
FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO
},
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
