Oliver Endriss wrote: > e9hack wrote: > > Oliver Endriss wrote: > > > Jon Burgess wrote: > > >> It appears the problem is that the driver is using streamed PCI and > > >> needs to explicitly sync the data otherwise it breaks when the SWIOTLB > > >> is in use. A call to pci_unmap_sg() was missing too. > > >> > > >> This patch is against the current v4l-dvb HG tree. > > >> > > >> I've only tested the change with a budget-ci card. > > > > > > Has anyone a problem with this patch? > > > If not I'll apply it tomorrow... > > > > If saa7146_pgtable_build_single() returns an error in saa7146_vmalloc_build_pgtable(), pci_free_consistent() should be > > also called. > > Correct, and pci_unmap_sg(), kfree() and vfree() must also be called. > > What about re-writing saa7146_vmalloc_build_pgtable(): > ... Ok, obsoleted by Jon's new patch in thread ' inconsistent use of saa7146_pgtable_free?' CU Oliver -- -------------------------------------------------------- VDR Remote Plugin 0.3.9 available at http://www.escape-edv.de/endriss/vdr/ -------------------------------------------------------- _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
