On Wed, 7 Mar 2007, Mauro Carvalho Chehab wrote: > Michael and Trent, > > Thanks for your comments. I've took the best suggestions from both of > you. The enclosed patch contains a reviewed patch. > > I'm also commenting a few stuff under Trent's email. > > Em Ter, 2007-03-06 às 13:29 -0800, Trent Piepho escreveu: > > > > > + 80 chars by line, like: > > ^per ^e.g. > > > > [Should we have the make commit script check the line length limits?] > > On CVS, we had a script, enforced at the server side, that used to check > for some stuff (From: SOB:, etc). I think it is a good idea to have a > check script for it. I think this could be added to the make commit logic. Run a script to check the commit message before calling hg commit. Or hg might have the ability to have some kind of pre-commit hook that checks commit messages. > > If HGUSER is not set, then, if present, the username defined in the user's > > ~/.hgrc file will be used. Use of the .hgrc file is preferred over the > > HGUSER variable according to the hg man page. > > I'm not sure if the scripts will handle .hgrc users properly. Can you > check it, please (It should to, but I'm not 100% if this is working > ok) ? I wrote the code to check .hgrc and it works for me. I think there might be some hgrc files that don't work, but I will fix that. _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
