Trent Piepho wrote: > There is one other difference. dvb-pll will probe for the presence of an > I2C pll chip by doing a one byte read, the lgh06xf driver did not do > this. In some devices the PLL is not reachable over I2C at the time the > tuner is attached. Some more initialization, such as firmware loading, > must take place first. If any of these devices are former LG-H06xF > users, something must be done to disable this probe or enable I2C before > attaching the tuner. LG-H06xF tuners do not have any sort of i2c gate or firmware loading situation, and will not be affected by this issue. So, we do not have to worry about this sort of problem. However, there are some small problems in the patch, which are easily fixable: --- a/linux/drivers/media/dvb/bt8xx/Kconfig Sun Feb 25 19:13:53 2007 -0800 +++ b/linux/drivers/media/dvb/bt8xx/Kconfig Sun Feb 25 19:13:58 2007 -0800 @@ -7,7 +7,7 @@ config DVB_BT8XX select DVB_CX24110 if !DVB_FE_CUSTOMISE select DVB_OR51211 if !DVB_FE_CUSTOMISE select DVB_LGDT330X if !DVB_FE_CUSTOMISE - select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE + select DVB_PLL select DVB_ZL10353 if !DVB_FE_CUSTOMISE select FW_LOADER help This should be: --- a/linux/drivers/media/dvb/bt8xx/Kconfig Sun Feb 25 19:13:53 2007 -0800 +++ b/linux/drivers/media/dvb/bt8xx/Kconfig Sun Feb 25 19:13:58 2007 -0800 @@ -7,7 +7,7 @@ config DVB_BT8XX select DVB_CX24110 if !DVB_FE_CUSTOMISE select DVB_OR51211 if !DVB_FE_CUSTOMISE select DVB_LGDT330X if !DVB_FE_CUSTOMISE - select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE + select DVB_PLL if !DVB_FE_CUSTOMISE select DVB_ZL10353 if !DVB_FE_CUSTOMISE select FW_LOADER help also: --- a/linux/drivers/media/dvb/dvb-usb/Kconfig Sun Feb 25 19:13:53 2007 -0800 +++ b/linux/drivers/media/dvb/dvb-usb/Kconfig Sun Feb 25 19:13:58 2007 -0800 @@ -98,7 +98,7 @@ config DVB_USB_CXUSB depends on DVB_USB select DVB_CX22702 if !DVB_FE_CUSTOMISE select DVB_LGDT330X if !DVB_FE_CUSTOMISE - select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE + select DVB_PLL select DVB_MT352 if !DVB_FE_CUSTOMISE select DVB_ZL10353 if !DVB_FE_CUSTOMISE help again, should be: --- a/linux/drivers/media/dvb/dvb-usb/Kconfig Sun Feb 25 19:13:53 2007 -0800 +++ b/linux/drivers/media/dvb/dvb-usb/Kconfig Sun Feb 25 19:13:58 2007 -0800 @@ -98,7 +98,7 @@ config DVB_USB_CXUSB depends on DVB_USB select DVB_CX22702 if !DVB_FE_CUSTOMISE select DVB_LGDT330X if !DVB_FE_CUSTOMISE - select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE + select DVB_PLL if !DVB_FE_CUSTOMISE select DVB_MT352 if !DVB_FE_CUSTOMISE select DVB_ZL10353 if !DVB_FE_CUSTOMISE help Apart from that, it all looks correct to me, but I ran into some problems unrelated to your change... For some reason, the build system in your tree doesn't want to build cx88-dvb.ko Even after doing "make allyesconfig" , I still get: .config:# CONFIG_VIDEO_CX88_DVB is not set Now, I do not see any changes in your tree that should cause this behavior, so one would normally write this off as user error... However, I have performed quite a few v4l-dvb hg builds on this box, and this is the first time this has ever happened. Putting that issue aside, I manually set CONFIG_VIDEO_CX88_DVB = m. I have tested this code on the FusionHDTV5 Gold and the FusionHDTV5 USB Gold. The devices seem to behave just as they did before. With i2c debug on with dvb-usb-cxusb, I can see the agc settings being written separately from the tuning settings: [17182238.752000] <<< 01 [17182238.752000] >>> 08 61 02 df 50 [17182238.756000] <<< 01 [17182238.756000] >>> 08 61 04 2c 90 ce 04 ...works well for me. Please make the fixes above to the Kconfig files before requesting merge into master. Acked-by: Michael Krufky <mkrufky@xxxxxxxxxxx> Regards, Mike _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
