On Tue, 23 Jan 2007 12:55:51 -0500 Michael Krufky <mkrufky@xxxxxxxxxxx> wrote: > Aapo Tahkola wrote: > > On Sun, 21 Jan 2007 16:11:21 -0500 > > Michael Krufky <mkrufky@xxxxxxxxxxx> wrote: > >> Please test the two following trees to confirm proper operation: > >> > >> http://linuxtv.org/hg/~mkrufky/megasky (expected to work for > >> everybody) > >> > >> http://linuxtv.org/hg/~mkrufky/megasky.new (possible problems > >> may occur with gl861) > > > > > Works as expected when using USB 2.0. > > HW: Megasky 580 with m9205, mt352 and qt1010. > > freq: fi-Rovaniemi > > Aapo, > > Does it work as expected in _BOTH_ trees? > > Argh, I just realized, that your Megasky device uses a mt352, not a > zl10353... Of course both trees will work for you. OK. In that > case, I feel that m920x is ready to be merged now. I actually tested both trees until realizing differences between them didn't weren't related my stick. :) > I am going to shuffle some patches around, and set things such that I > can merge m920x while holding gl861 and au6610 behind until we can > resolve the issue with that zl10353 patch. > > > This patch fixes USB1.1 support. > > The patch below is not entirely accurate, and you forgot to send in a > sign-off. > > This patch is more appropriate... Feel free to respond with your > s-o-b: > Signed-off-by: Aapo Tahkola <aet@xxxxxxxxxxxxxx> > Signed-off-by: Michael Krufky <mkrufky@xxxxxxxxxxx> > > --- megasky.orig/linux/drivers/media/dvb/dvb-usb/m920x.c > +++ megasky/linux/drivers/media/dvb/dvb-usb/m920x.c > @@ -465,8 +465,7 @@ static struct usb_device_id m920x_table > MODULE_DEVICE_TABLE (usb, m920x_table); > > static struct dvb_usb_device_properties megasky_properties = { > - .caps = DVB_USB_IS_AN_I2C_ADAPTER | > DVB_USB_ADAP_HAS_PID_FILTER | > - DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF, > + .caps = DVB_USB_IS_AN_I2C_ADAPTER, > > .usb_ctrl = DEVICE_SPECIFIC, > .firmware = "dvb-usb-megasky-02.fw", > @@ -482,6 +481,9 @@ static struct dvb_usb_device_properties > .identify_state = megasky_identify_state, > .num_adapters = 1, > .adapter = {{ > + .caps = DVB_USB_ADAP_HAS_PID_FILTER | > + DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF, > + > .pid_filter_count = 8, > .pid_filter = m9206_pid_filter, > .pid_filter_ctrl = m9206_pid_filter_ctrl, > > > -- Aapo Tahkola _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb