The original code written for analog mode was designed to tune quickly by increasing the pump current then switch back to the more stable current value after the signal was acquired. This makes switching channels that are far apart in frequency stabilize sooner. I did not attempt to add this improvement to the dvb tuning code since that code was already working. That is why there are two different ways to tune the same hardware. Before refactoring, the analog code always initialized all 4 bytes that were sent to the tuner to values specified for that particular tuner. For my driver I arranged to select fast tuning with the default code in the tuner table, then set it to the more stable value when the tuning was done. Was something lost in refactoring? I'll look at the code in the kernel and try to understand what need to be done. -- Mac On Monday 10 July 2006 19:42, Michael Krufky wrote: > Hmm... Looks like you're right. We always set 0x50 > during digital tuning in lg_h06xf_pll_set, but it looks > like 0x20 is only set during tuner_set_type. Meanwhile > both analog and digital modes are functioning properly. > I wouldn't really want to change this without first > hearing from Mac Michaels. > > > The real problem is that there are two different tuner > > drivers, both controlling the same tuner, and they > > don't know anything about each other. A real solution > > would have to address this fundamental design flaw of > > V4L + DVB: two drivers for the same hardware stepping > > on each other's toes. > > This is a fundamental flaw that has been spoken about > many times before. > > I am not going to comment on it. > > Just wait a bit and see what things look like after the > upcoming refactoring. > > > Still, a stop-gap fix can be made now. The tuner needs > > to program the AB either: > > 1) When the V4L device is opened > > 2) Every time the tuner is programmed > > For now, if it's not broken, don't fix it. Let's see > what Mac says, first. > > > 1 would be more efficient, but won't handle the case of > > using both the V4L and DVB devices at the same time. > > This is possible, but doesn't actually work so well, or > > make much sense. So I don't see that as much of a > > problem. 2 might well be easier to impliment. > > Each time the pll is tuned to a digital channel, 0x50 is > sent. I thought that 0x20 was always sent when tuning > analog channels, but now I see that it isnt. > > Mac, can you comment on any of this? _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
