On Mon, May 22, 2006, Manu Abraham wrote:
> Johannes Stezenbach wrote:
> >For binary compatibility it isn't sufficient to just add new
> >fields to struct dvbs2_params. There must also be an indicator
> >which the kernel can use to see if struct dvb_frontend_params
> >was prepared by old or new userspace, i.e. if the new fields
> >are valid or contain uninitialized data.
> >
> >That's why I propsed a "flags" field for struct dvbs2_params
> >in my version of the patch.
> >
>
>
> +/*
> + * DVB-S2 parameters
> + * ETSI EN 302 307, TR 102 376, EN 301 210
> + */
> +struct dvbs2_params {
> + __u32 symbol_rate;
> + __u32 flags; /* for future use, must be 0 for now */
> +
> + enum dvb_fe_modulation modulation;
> + enum dvb_fe_fec fec;
> + enum dvb_fe_rolloff rolloff;
> + enum dvb_fe_stream_priority priority;
> +};
>
>
> And , what do these flags do ? I hope it is not a secret.
Currently nothing, as the comment says.
> Well, this implementation is perfectly broken. I don't want to argue on
> this damn thing. i don't know why you are arguing for a damn broken thing.
>
> Can you please explain how you will be using this godamn thing ? I don't
> know how to use this.
e.g. a future version could look like this:
struct dvbs2_params {
__u32 symbol_rate;
__u32 flags; /* for future use, must be 0 for now */
#define DVBS2_SET_STREAM_ID (1 << 0)
enum dvb_fe_modulation modulation;
enum dvb_fe_fec fec;
enum dvb_fe_rolloff rolloff;
enum dvb_fe_stream_priority priority;
__u8 stream_id;
};
...if it turns out that we really need it.
Johannes
_______________________________________________
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
