Johannes Stezenbach wrote:
On Fri, May 19, 2006, Marcel Siegert wrote:
a) don't get any kind of e.g. memcopy problems with new structs and old
kernels after
this patch went in. so the size of e.g. the tuning params for dvb-s2 can
be extended
without having to change the structs size. so also old kernel will
perform a correct
memcopy.
For binary compatibility it isn't sufficient to just add new
fields to struct dvbs2_params. There must also be an indicator
which the kernel can use to see if struct dvb_frontend_params
was prepared by old or new userspace, i.e. if the new fields
are valid or contain uninitialized data.
That's why I propsed a "flags" field for struct dvbs2_params
in my version of the patch.
+/*
+ * DVB-S2 parameters
+ * ETSI EN 302 307, TR 102 376, EN 301 210
+ */
+struct dvbs2_params {
+ __u32 symbol_rate;
+ __u32 flags; /* for future use, must be 0 for now */
+
+ enum dvb_fe_modulation modulation;
+ enum dvb_fe_fec fec;
+ enum dvb_fe_rolloff rolloff;
+ enum dvb_fe_stream_priority priority;
+};
And , what do these flags do ? I hope it is not a secret.
Well, this implementation is perfectly broken. I don't want to argue on
this damn thing. i don't know why you are arguing for a damn broken thing.
Can you please explain how you will be using this godamn thing ? I don't
know how to use this.
*sigh*
Manu
_______________________________________________
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
