On Sat, 20 May 2006, Manu Abraham wrote: > Trent Piepho wrote: > > Look at all the dvbfe_xxx_info structs. They all have 32 bytes of padding. > > This means they are all bigger than 32 bytes, right? Then the union they are > > in has 32 bytes of padding. But all the structs are bigger than 32 bytes, so > > this padding does nothing! > > > > > > So your only issue is that of the padding inside the union is useless. > Any other issues you have ? It's really the other way around, the padding inside xxx_info and inside dvbs2_params (none of the other xxx_params have padding) is useless. The padding inside the union takes care of it. > Regarding your other comment i don't think LK folks would accept such a > convoluted way. I wonder if they will have issues with having bitflags inside an enum. This means when multiple flags are set, the enum isn't one of it's enumerated values. I like the enums, but I see how someone would complain. Is there any reason that when an enum has _AUTO it can't be set to (1<<31) to avoid putting in _DUMMY? _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
