Em Dom, 2006-05-14 às 17:11 +0200, christophpfister@xxxxxxxxxxx escreveu: > >On Sun, 14 May 2006, Mauro Carvalho Chehab wrote: > > > >I have a version that I thought was nicer, but it requires changing the > >includes in konicawc.c a bit. > > > >diff konicawc.c > >#include <linux/kernel.h> > >#include <linux/module.h> > >#include <linux/init.h> > >#include <linux/input.h> > >+#include <linux/usb.h> > >+#include "compat.h" /* it's either this or version.h */ > >+#ifndef V4LCOMPAT_NO_USB_INPUT > >+#include <linux/usb_input.h> > >+#endif > > > >code in compat.h: > > > >/* only use this if linux/usb.h and linux/input.h have been included */ > >#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,13) && \ > > defined(__LINUX_USB_H) && defined(_INPUT_H) > >/* Found in linux/usb_input.h in 2.6.13 */ > >#define V4LCOMPAT_NO_USB_INPUT > >static inline void > >usb_to_input_id(const struct usb_device *dev, struct input_id *id) > > > >I think this version is much nicer, but it means that after the compat > >stuff is stripped, there will be an extra #include <linux/usb.h>. > > Just a general consideration (I didn't follow this thread, so I may be wrong...): > > If only the order of includes matters, I'd suggest to include linux/usb.h > and linux/input.h inside compat.h. (That shouldn't bother bother non-usb > devices.) This seems good. You may include both if kernel<2.6.13. > Cheers, Mauro. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
