On Sun, 14 May 2006 christophpfister@xxxxxxxxxxx wrote: > > Just a general consideration (I didn't follow this thread, so I may be wrong...): > > If only the order of includes matters, I'd suggest to include linux/usb.h > and linux/input.h inside compat.h. (That shouldn't bother bother non-usb > devices.) My original patch said what is wrong with that. linux/usb.h defines a number of symbols that conflict with other code in non-usb drivers. You can't add linux/usb.h to compat.h for drivers that didn't have it already. I've come up with two options: 1. Require that linux/usb.h and linux/input.h are included before compat.h to turn on linux/usb_input.h compatibility. 2. Define V4L_COMPAT_USB_INPUT before including compat.h to turn on linux/usb_input.h compatibility. The first one is nicer looking and cleaner, but the second would be easier to strip out be gentree.pl. Of course the first doesn't NEED to be stripped, there is nothing wrong with putting an include in another spot, it's just a cosmetic change. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
