Re: [PATCH] Re: [PATCH] Multi protocol support (stage #1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Trent Piepho wrote:
On Sat, 6 May 2006, Johannes Stezenbach wrote:
On Sat, May 06, 2006, Trent Piepho wrote:
My thought would be that GET_PARAMS with delivery set to FE_DELSYS_IGNORE
would just return frequency.  SET_PARAMS with FE_DELSYS_IGNORE would just set
the frequency (and inversion?  Why is inversion here?) and leave the rest of
the parameters as is.

It's not specified anywhere, but I thought that GET_CAPS with delivery
set to FE_DELSYS_IGNORE (wasn't there a QUERY before?) would return
the supported delsyses.  Like this:

int check_for_atsc(int fd)
{
    struct dvb_frontend_cap;
    cap.delivery = FE_DELSYS_IGNORE; // Get FE type
Thanks, now I get why there once was a FE_DELSYS_QUERY. This
is totally not obvious from reading frontend.h, it needs to
be documented with a comment.

Well, that's how *I* thought it would work.  I guess Manu has another idea.
I thought ignore for all the various params was only for GET_PARAMS, to avoid
unnecessary I2C traffic.  GET_CAPS just returns constant values, I can't see
what point IGNORE would have.  I just makes get_params in the driver more
complicated.

There is no real spec or example code yet, so I will write some for
FE_GET_CAPS.  I hope Manu will correct what I get wrong.  IMHO, nothing
I'm writing contradicts anything in Manu's latest multi-protocol support
patch.


Trent,

I will get back on this


Manu



_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux