Trent Piepho wrote:
On Tue, 2 May 2006, Manu Abraham wrote:
Trent Piepho wrote:
can be moved into the core at that time. The modcod enum doesn't belong in
the public header file since nothing in the public interface uses it.
No, since it is part of the spec and not having anything to do with the
driver as it is. Some drivers return this explicitly as part of register
settings , not all drivers do comply.
Why aren't there other enums for constants found in section data? What makes
modcod special?
Huh ? You want to add demux specific things into the frontend ?
The one's that's in section data , goes to the demux, not to the
frontend. Currently at this stage, doing only the frontend specifics.
References: EN 302 307, TR 102 376
We are _not_ looking at the demux API, right now, but _only_ the
frontend API. Modified files are frontend.h, dvb_frontend.c, dvb_frontend.h
First, how about adding QAM_512 and QAM_1024 in the expected spot. There is
already DOCSIS cable modem cardware than can use these modulations. You might
want to add VSB_16 too, it's part of the ATSC spec.
ok, will add QAM_512 and QAM_1024
No VSB_16? It's defined in A/53.
ah, ok, QAM_512, QAM_1024, VSB_16. Will add them.
The driver has to choose the relevant modulation. Modulation Auto is
used in the case where the hardware can tell the driver whether it can
support the same. Or the driver is capable. Current single standard
(delivery system) drivers/hardware do not support this.
So what you are saying is that the ability of some demodulators to
automatically detect the QAM constellation will no longer be supported?
No. You mean, you want to add QAM_AUTO, PSK_AUTO etc ? Ok, i will add
MOD_"MODTYPE"_AUTO, if it is useful.
If you see the structure, i have put this struct only for maintaining
the naming consistency. If i put the pad[512] into the union
straightaway, that consistency is lost.
You could name it __u8 pad_parms[512].
It's a matter of taste, that's all.
_______________________________________________
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
