I've been working on updating the genpix driver to work with your latest DVB-S2 patch (to see what is involved, as well as to get something closer to what will finally be released, as people are already using the crude hack I posted a couple of months ago) How do you expect the frontend to know which parameters to use? It looks like you've defined set_frontend2 which I assume can be used in place of set_frontend, but it isn't actually called anywhere yet (that's ok, i can put in the relevant calls). The issue I have is that set_frontend is called from dvb_frontend_swzigzag_autotune and dvb_frontend_swzigzag both of which examine fepriv->parameters. Do you expect to update these functions to use fepriv->parameters_new (I assume so)? if so, how do you know when to use one vs the other? Is the presence of non-zero fepriv->current_standard_set good enough to know we should be using FE_SET_FRONTEND2? Or is fepriv->parameters_new != NULL a better method? what if the app had called FE_SET_FRONTEND2 last time, but this time around used FE_SET_FRONTEND? also, as you removed all of the other 'new' methods, perhaps fepriv->parameters_new should instead be fepriv->parameters2? Once I figure out your intentions on passing the new tuning parameters to the driver, I don't foresee any additional issues with actually getting the driver working with them. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
