Hi,
Jose Alberto Reguero wrote:
> El Martes, 31 de Enero de 2006 20:22, Michael Krufky escribi?:
>
>>Jose Alberto Reguero wrote:
>>
>>>El Lunes, 30 de Enero de 2006 22:27, Hartmut Hackmann escribi?:
>>>
>>>>Ok, at the first glance there is only a minor issue with this patch and
>>>>it will not give optimum performance if the Philips recommendatios are
>>>>right.
>>>>I was not aware that dvb-pll already just provides the byte lists, so
>>>>we can agree to move the tuning code for MT352 to dvb-pll as a
>>>>compromise.
>>>
>>>I think that this patch solves the issue you mentioned. I think that now
>>>is the same code that without dvb-pll.
>>>
>>>
>>>--- v4l-dvb/linux/drivers/media/dvb/frontends/dvb-pll.c 2006-01-31
>>>09:46:16.000000000 +0100 +++
>>>v4l-dvb.new/linux/drivers/media/dvb/frontends/dvb-pll.c 2006-01-31
>>>09:29:20.000000000 +0100 @@ -391,15 +391,15 @@
>>> .setbw = td1316_bw,
>>> .count = 9,
>>> .entries = {
>>>- { 130000000, 36166000, 166666, 0xca, 0x60},
>>>- { 160000000, 36166000, 166666, 0xca, 0xa0},
>>>- { 200000000, 36166000, 166666, 0xca, 0xc0},
>>>- { 290000000, 36166000, 166666, 0xca, 0x60},
>>>- { 420000000, 36166000, 166666, 0xca, 0xa0},
>>>- { 480000000, 36166000, 166666, 0xca, 0xc0},
>>>- { 620000000, 36166000, 166666, 0xca, 0x60},
>>>- { 830000000, 36166000, 166666, 0xca, 0xa0},
>>>- { 895000000, 36166000, 166666, 0xca, 0xe0},
>>>+ { 938340000, 36166000, 166666, 0xca, 0x60},
>>>+ { 123834000, 36166000, 166666, 0xca, 0xa0},
>>>+ { 163834000, 36166000, 166666, 0xca, 0xc0},
>>>+ { 253834000, 36166000, 166666, 0xca, 0x60},
>>>+ { 383834000, 36166000, 166666, 0xca, 0xa0},
>>>+ { 443834000, 36166000, 166666, 0xca, 0xc0},
>>>+ { 583834000, 36166000, 166666, 0xca, 0x60},
>>>+ { 793834000, 36166000, 166666, 0xca, 0xa0},
>>>+ { 858834000, 36166000, 166666, 0xca, 0xe0},
>>> },
>>>};
>>>EXPORT_SYMBOL(dvb_pll_philips_td1316);
>>
>>Jose-
>>
>>The patch above doesnt make any sense... The ranges should be in order
>>from min to max... Hartmut has already applied your last patch, but this
>>one is obviously incorrect.....
>>
>>Is the current code in Hg not working correctly?
>>
>>If not, then the patch above should be corrected, but I'm not sure that
>>I understand what you're trying to do, here.
>>
>>Regards,
>>
>>Michael Krufky
>
>
> I have a mistake in the patch.
> The idea is to subtract 36166000 to the ranges, because the older code add
> 36166000 to the frequencie before to compare it with the ranges.
> I attach the patch again, but is not to much diference .Both codes work.
>
The issues i mentioned was that the patch did include dvb-pll.h "by accident"
I corrected this already. I would also expect that your latest patch does not
make a big difference but i will apply it to have things as correct as posible.
Jose, can you please test again and report after i commited it?
I have no means to do this myself.
Thanks
Hartmut
