On 1/1/06, Johannes Stezenbach <js@xxxxxxxxxxx> wrote:
> On Sun, Jan 01, 2006, Michael Krufky wrote:
> > Is it okay to use Patrick's second suggestion (use d->pll_init directly
> > without bpll), as illustrated in the patch attached?
> >
> > I like this method best, as it does exactly as what I had originally
> > intended.
>
> Assuming that d->pll_init is initialized to zero it's OK.
> But I still like the simple = { 0x00, 0x00, 0x18, 0x50 }
> better, because a) it's simpler, b) someone who tries to understand
> the code doesn't have to scratch their heads as to wtf you do a
> &= ~0x20 and |= 0x18 on a value initialized to zero. If you would
> comment what it does it would make sense, but so it is misleading
> as people will assume pll_init[] was priviously initialized to something
> else, then search the code just to find it wasn't.
Okay. I will do, = { 0x00, 0x00, 0x18, 0x50 }
...and I'll also add the spaces after the ","
Thanks,
Michael
