Patrick Boettcher wrote:
> Hi Graham,
>
> sorry for this mess. But congratulations to your fix.
>
> On Fri, 3 Feb 2006, Graham Finlayson wrote:
>
>> static u8 clock_config [] = { CLOCK_CTL, 0x38, 0x38 };
>> static u8 config [] = { CONFIG, 0x28 };//ADDED
>> static u8 reset [] = { RESET, 0x80 };
>> static u8 adc_ctl_1_cfg [] = { ADC_CTL_1, 0x40 };
>> static u8 agc_cfg [] = { AGC_TARGET, 0x28, 0x20 };
>> static u8 gpp_ctl_cfg [] = { GPP_CTL, 0x33 };
>> static u8 capt_range_cfg[] = { CAPT_RANGE, 0x32 };
>>
>> mt352_write(fe, clock_config, sizeof(clock_config));
>> mt352_write(fe, config, sizeof(config));//ADDED
>> udelay(200);
>>
>> and I can now start mplayer and mythtv with no issues. I would guess
>> that this should be added to the other mt352 demod init functions, but
>> cannot test that.
>
>
> I _really_ thought the driver was tested on _at least_ one board before
> its patch was added to tree... Obviously not the case then.
>
> Who will commit the change, Michael, Chris?
Patrick-
This is the device that Chris wrote the patch for. He has tested the
device, using cxusb_dee1601_demod_init . Strange.....
cxusb_mt352_demod_init is for the other two fusionhdtv dvb-t boxes, it
probably needs this change as well, but I have no device to test with.
(I wrote that patch, and it was tested on the list). Since I copied
this function from cx88-dvb.c , the mt352_demod_init functions there
might need this as well. Maybe Chris can tell us something - he wrote
the mt352 stuff in cx88-dvb as well.....
Chris-
Would you test the above change on your device and let us know what
happens? It looks like this change should be made across the board. If
this is needed everywhere, maybe we can centralize it for every
implementation... What do you think?
Thanks,
Michael
