Edgar Toernig wrote: > Michael Krufky wrote: > >>>>>bt878(0): irq FDSR risc_pc=2c4bd008 >> >>diff -u -p -r1.49 dvb-bt8xx.c >>--- linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c 10 Sep 2005 07:26:02 >>-0000 1.49 >>+++ linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c 11 Sep 2005 19:19:26 -0000 >>@@ -828,8 +828,8 @@ static int dvb_bt8xx_probe(struct device >> case BTTV_DVICO_FUSIONHDTV_5_LITE: >> #endif >> card->gpio_mode = 0x0400c060; >>- card->op_sync_orin = 0; >>- card->irq_err_ignore = 0; >>+ card->op_sync_orin = BT878_RISC_SYNC_MASK; >>+ card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR | >>BT878_APABORT | BT878_ARIPERR | BT878_APPERR; >> break; >>I suspect that it is safe to keep it as it shown in the patch above... >>Please confirm. > > > The patch I send a couple a days ago did exactly that. It's right. > > Furthermore, irq_err_ignore and op_sync_orin are _not_ card specific. > With irq_err_ignore you can disable debug messages that are specific > to the bt878 dma controller and that is same on all cards. > And the only use of op_sync_orin is an added resync for some cards. > But again, this is bt878 dma specific and all cards benefit from a > resync - without it the dma-controller won't recover from errors. > > So, just remove all the op_sync_orin and irq_err_ignore stuff and > add the appropriate bits directly in bt878.c. You can look at > my patch how to do it ... > Edgar- I have seen your patch, and I can't say that I disagree with you. Remember, I applied the v4l portion of it to video4linux cvs. However, Manu knows a lot more about bt878 that I do. As far as the dvb-kernel portion of the patch, Manu has made comments to you about it and you have yet to respond to him. http://www.linuxtv.org/pipermail/linux-dvb/2005-September/004492.html Please, follow up with Manu about this and get him to apply it, or a modified version of it for you. You will have to regenerate your patch against current cvs, of course. Your patch has helped Lukas with his PCTV Sat card, and it would be nice for you to take Manu's advice on these changes, before we apply them. -- Michael Krufky
