Johannes Stezenbach wrote: >Michael Krufky wrote: > > >>The attached patch has been revised to correct the sync byte for MPEG-2 >>transport stream packets. Detailed changelog is included in the header >>of the patch. >> >> >... > > >>- Let Kconfig decide whether to include frontend-specific code in cx88-dvb. >> >> linux/drivers/media/dvb/frontends/dvb-pll.c | 13 ++++ >> linux/drivers/media/dvb/frontends/dvb-pll.h | 1 >> linux/drivers/media/video/cx88/cx88-cards.c | 3 - >> linux/drivers/media/video/cx88/cx88-dvb.c | 57 ++++++++++++++------ >> linux/drivers/media/video/cx88/cx88-mpeg.c | 8 +- >> >> > >Besides that the patch lacks the Kconfig changes which >would make the #ifdef mess useful, I still advise >against it. It is just not userfriendly if you require >users to find out what frontend driver the need for their card. >We had that in the past, and I think most people like >the current approach better. > >just my 2?, >Johannes > > Johannes- I just relalized that my previous email was in slight error..... I need to add select DVB_LGDT3302 into the cx88-dvb section of Kconfig. Anyhow, back to my previous point... cx88-dvb already had the #ifdef HAVE_FRONTEND ... I am just renaming this symbol to #ifdef CONFIG_DVB_FRONTEND when cx88-dvb is selected in kconfig, all four frontends will be selected. What I am trying to do here is remove the #DEFINE from the top of the file, and have kconfig (or makefile) be in charge of selecting these frontends..... In the end, all frontends will be built anyhow.... It is just a matter of moving the selection into kconfig and out of the #DEFINE's in cx88-dvb (and saa7134-dvb). I just got your email... looks like you already see what i mean. -- Michael Krufky
