On Tue, 28 Jun 2005, Johannes Stezenbach wrote:
> Michael Krufky wrote:
>> This driver for the LGDT3302 frontend, used by the DViCO FusionHDTV3
>> Gold cx88-based hybrid analog/dvb pci card was written by Mac Michaels,
>> and is currently in the video4linux CVS. Please apply this to DVB
>> kernel as soon as possible.
>>
>> Signed-off-by: Mac Michaels <wmichaels1@xxxxxxxxxxxxx>
>> Signed-off-by: Michael Krufky <mkrufky@xxxxxxx>
>
>> +#define dprintk(args...) \
>> +do { \
>> +if (debug) printk(KERN_DEBUG "lgdt3302: " args); \
>> +} while (0)
>
> Interesting formatting...
>
> This patch adds a lot of whitespace at end-of-line. After you
> cleaned that up, please commit it to CVS by yourself, adding
> the Signed-off-by: lines to the commit message.
IMO you can remove the
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,10)
code. dvb-kernel only compiles cleanly with >= 2.6.12, thus this
dependency should be fulfilled.
regards,
Patrick.
