On Fri, May 20, 2005 at 08:52:25PM +0200, Francois Romieu wrote:
> -static int dmx_unregister_demux(struct dmx_demux* demux)
> +static void dmx_unregister_demux(struct dmx_demux *demux)
> {
> - struct list_head *pos, *n, *head=&dmx_muxs;
> + struct list_head *pos, *n, *head = &dmx_muxs;
>
> list_for_each_safe (pos, n, head) {
> if (DMX_DIR_ENTRY(pos) == demux) {
> - if (demux->users>0)
> - return -EINVAL;
> + if (demux->users > 0) {
> + printk(KERN_ERR "dvb_demux.c: still in use\n");
You should make that a WARN_ON().
Johannes
