Hartmut Hackmann wrote: >>And even against latest v4l tarball there are quite a few rejects >>in part 2 and 3. > > > That's crazy, I checked against the snapshot i mentioned. > Can you please describe precisely which code you tried to patch and > what went wrong? Using: video4linux-20050426-090128.tar.gz $ patch -p1 < ../../q/\[linux-dvb\]\ Driver\ for\ Medion\ MD7134\ Cardbus\ and\ PCI\,\ Part\ 2\ of\ 3.eml patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 2. patching file Makefile Hunk #1 FAILED at 40. 1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej patching file audiochip.h Hunk #1 FAILED at 31. 1 out of 1 hunk FAILED -- saving rejects to file audiochip.h.rej patching file load_modules patching file rm_modules patching file saa7134-cards.c Hunk #1 FAILED at 474. Hunk #2 FAILED at 1545. Hunk #3 FAILED at 1863. 3 out of 3 hunks FAILED -- saving rejects to file saa7134-cards.c.rej patching file saa7134-core.c Hunk #1 FAILED at 722. Hunk #2 FAILED at 989. 2 out of 2 hunks FAILED -- saving rejects to file saa7134-core.c.rej patching file saa7134-dvb.c Hunk #1 FAILED at 3. Hunk #2 FAILED at 144. Hunk #3 FAILED at 395. Hunk #4 FAILED at 418. 4 out of 4 hunks FAILED -- saving rejects to file saa7134-dvb.c.rej patching file saa7134-ts.c Hunk #1 FAILED at 221. 1 out of 1 hunk FAILED -- saving rejects to file saa7134-ts.c.rej patching file saa7134-video.c Hunk #1 FAILED at 1218. Hunk #2 FAILED at 1234. Hunk #3 FAILED at 1275. Hunk #4 FAILED at 1384. 4 out of 4 hunks FAILED -- saving rejects to file saa7134-video.c.rej patching file saa7134.h Hunk #1 FAILED at 197. 1 out of 1 hunk FAILED -- saving rejects to file saa7134.h.rej patching file tda9887.c Hunk #1 FAILED at 61. Hunk #2 FAILED at 232. Hunk #3 FAILED at 371. Hunk #4 FAILED at 570. Hunk #5 FAILED at 624. Hunk #6 FAILED at 691. 6 out of 6 hunks FAILED -- saving rejects to file tda9887.c.rej patching file tuner-core.c Hunk #1 FAILED at 149. Hunk #2 FAILED at 289. 2 out of 2 hunks FAILED -- saving rejects to file tuner-core.c.rej patching file tuner-simple.c Hunk #1 FAILED at 212. Hunk #2 FAILED at 429. Hunk #3 FAILED at 466. 3 out of 3 hunks FAILED -- saving rejects to file tuner-simple.c.rej patching file tuner.h Hunk #1 FAILED at 97. Hunk #2 FAILED at 122. Hunk #3 FAILED at 180. 3 out of 3 hunks FAILED -- saving rejects to file tuner.h.rej jdittmer@ds666:~/src/lk/v4l/video4linux.hh$ patch -p1 < ../../q/\[linux-dvb\]\ Driver\ for\ Medion\ MD7134\ Cardbus\ and\ PCI\,\ Part\ 3\ of\ 3.eml patching file saa7134-oss.c Hunk #1 FAILED at 49. Hunk #2 FAILED at 56. Hunk #3 FAILED at 76. Hunk #4 FAILED at 160. Hunk #5 FAILED at 548. Hunk #6 FAILED at 816. Hunk #7 FAILED at 835. 7 out of 7 hunks FAILED -- saving rejects to file saa7134-oss.c.rej patching file saa7134-tvaudio.c Hunk #1 FAILED at 181. Hunk #2 FAILED at 251. And I checked - I've tabs in these saved files. > To be honest: > I am not happy with the idea of creating development patches against > the mm or linus trees. These change too often and my impression is that > this causes significant additional work. Well, I think the drivers/media dir is quite stable and personally I find it a lot easier to apply patches against a working linus or mm tree. -- Jan
