Gerd Knorr wrote: >>--- bttv-cards.c.orig 2005-04-04 02:20:21.000000000 +0400 >>+++ bttv-cards.c 2005-04-04 02:35:25.000000000 +0400 >>@@ -2574,7 +2574,7 @@ void __devinit bttv_init_card1(struct bt >> btv->use_i2c_hw = 1; >> break; >> } >>- if (!bttv_tvcards[btv->c.type].has_dvb) >>+ if (!bttv_tvcards[btv->c.type].has_dvb && !btv->use_i2c_hw) >> bttv_reset_audio(btv); > > > Shouldn't be needed, the twinhan is tagged as "has_dvb" anyway. > > >>- bttv_reset_audio(btv); >>+ if (!btv->use_i2c_hw) >>+ bttv_reset_audio(btv); > > > Try dropping the bttv_reset_audio() call altogether, it's redundant. > Why do we have all these redundant stuff into bttv which broke hell out for people ? Is there anymore redundant stuff, that people should be aware of ? If we know which all redundant parts are in there, it would be easier for fixes later on ? ;-) Twinhan and Avermedia users please do check out the patch such that more interesting *redundant* code has not been missed out from the patch, Guys, all please do cooperate, a request ... and give one more round of tests please ...... Thanks, Manu -------------- next part -------------- A non-text attachment was scrubbed... Name: bttv-cards.c.diff Type: text/x-patch Size: 403 bytes Desc: not available Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20050404/088b5c60/bttv-cards.c.bin
