Hi Gregor, Oliver, On Thursday 17 March 2005 20:20, Gregor Kroesen wrote: > Oliver Endriss wrote: > > Gregor Kroesen wrote: > > > >>this is my patch for "Hauppauge Nova-s usb": > >> > >>ftp://ftp.ccamp.de/pub/dvb/nova-s-usb-bsbe1.patch > >> > >>I hope it is ok for V0.0 - V2.1 ? > > > > > > Hm, some comments: > > > > + if(ttusb->hw_config) { > > + alps_bsxxn_inittab[sizeof(alps_bsxxn_inittab)-3]=0x92; > > > > You must not patch inittab. Otherwise the driver will not work with two > > different devices (BSRU6 + BSBE1). I suggest to use a separate table, > > so it can be optimized for each type of tuner. > > According to > ftp://ftp.ccamp.de/pub/dvb/BSBE1_701A.pdf > the difference of the "INITTAB" is only bit 0x0f: 0x52 -> 0x92 > (not 0xd2). hw_config is 0x00 for BSRU6 and 0x01 for BSBE1. > So it should work for the older inittab. Istead of having the stv0299 inittab with slightly different values all over the place, what about having a default inittab in stv0299.c, and replace the inittab field of stv0299_config with a patch_inittab function that is called after the default have been loaded? Kenneth
