Re: [PATCH] drivers/staging/emxx_udc: avoid > 80 character lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 26, 2017 at 01:57:14PM -0300, Tiago Koji Castro Shibata wrote:
> Fix checkpatch.pl "WARNING: line over 80 characters"
> 
> Signed-off-by: Tiago Koji Castro Shibata <tiago.shibata@xxxxxxxxx>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 77b242e09932..5abb5922ad7d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -912,7 +912,8 @@ static int _nbu2ss_epn_out_pio(
>  	if (data > 0) {
>  		/*---------------------------------------------------------*/
>  		/* Copy of fraction byte */
> -		Temp32.dw = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_READ);
> +		Temp32.dw =
> +		_nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_READ);

That's horrid code now, and does not follow the coding style rules.
Sorry, you can't "fix" one thing and make the code worse :)

Remember, checkpatch.pl is a "guide", sometimes it doesn't make sense to
change anything, like here.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux