On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote: > isp_capture_defs.h: clean up ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Haim Daniel <haimdaniel@xxxxxxxxx> > --- > .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > index aa413df..117c7a2 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > @@ -19,7 +19,7 @@ > #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */ > #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 ) > #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */ > -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM > +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM) Why only fix one of these instances? And why is this define even needed? No one touches it, right? Also, please cc: Alan on patches to this driver when you resend. You are using scripts/get_maintainer.pl, right? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
