Hi,
On 10-04-17 21:52, Greg Kroah-Hartman wrote:
On Mon, Apr 10, 2017 at 09:02:36PM +0200, Hans de Goede wrote:
Hi,
On 09-04-17 21:06, Greg Kroah-Hartman wrote:
On Sun, Apr 09, 2017 at 11:40:15AM +0200, Hans de Goede wrote:
Hi,
On 09-04-17 11:37, Greg Kroah-Hartman wrote:
On Sun, Apr 09, 2017 at 05:02:01PM +0800, kbuild test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head: 6cb3d05f3030deed157c9bbada5c58e7ee0f5172
commit: 554c0a3abf216c991c5ebddcdb2c08689ecd290b [751/807] staging: Add rtl8723bs sdio wifi driver
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 554c0a3abf216c991c5ebddcdb2c08689ecd290b
# save the attached .config to linux build tree
make.cross ARCH=powerpc
This driver needs to be prevented from being built into the kernel, and
made only as a module to handle these "global symbol" errors.
Hans, care to send me a patch for it?
Sure, if someone can tell me the necessary Kconfig magic
for that. I'm not aware of any way to force something being
a module only, I guess there is some trick to this, but nothing
straight forward comes to mind.
I'm pretty sure:
depends on MODULES
does this, or something like that.
Ok, so I checked and all depends on MODULES does is check that module
support is enabled, but the driver can still be built-in.
I googled for some solution but couldn't find any I'm afraid.
'depends on m' should do the trick. Try that.
I see you've already fixed this, thank you.
Note FWIW that this problem already existed for some other symbols
for some of the other rtl8* drivers in staging.
Yes I agree, which is why most of those drivers have that line in their
Kconfig file. We should also add it to the one that this driver
conflicted with as well :)
The driver this conflicted with for the specific symbol of this
thread: rtl8723B_leave_lps_flow is rtlwifi:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/pwrseq.c
I'm not sure if it is a good idea to add 'depends on m' to that
as it is not in staging and some people my be using it builtin
currently.
OTOH Stephen Rothwell was seeing a ton of concflicts with
drivers/staging/rtl8188eu so I will send you a patch adding
'depends on m' there as that seems like a good idea.
Regards,
Hans
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
