Re: [staging:staging-next 751/807] drivers/staging/rtl8723bs/hal/Hal8723BPwrSeq.o:(.data+0x138): multiple definition of `rtl8723B_leave_lps_flow'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 10, 2017 at 09:02:36PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 09-04-17 21:06, Greg Kroah-Hartman wrote:
> > On Sun, Apr 09, 2017 at 11:40:15AM +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 09-04-17 11:37, Greg Kroah-Hartman wrote:
> > > > On Sun, Apr 09, 2017 at 05:02:01PM +0800, kbuild test robot wrote:
> > > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> > > > > head:   6cb3d05f3030deed157c9bbada5c58e7ee0f5172
> > > > > commit: 554c0a3abf216c991c5ebddcdb2c08689ecd290b [751/807] staging: Add rtl8723bs sdio wifi driver
> > > > > config: powerpc-allyesconfig (attached as .config)
> > > > > compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> > > > > reproduce:
> > > > >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > >         chmod +x ~/bin/make.cross
> > > > >         git checkout 554c0a3abf216c991c5ebddcdb2c08689ecd290b
> > > > >         # save the attached .config to linux build tree
> > > > >         make.cross ARCH=powerpc
> > > > 
> > > > This driver needs to be prevented from being built into the kernel, and
> > > > made only as a module to handle these "global symbol" errors.
> > > > 
> > > > Hans, care to send me a patch for it?
> > > 
> > > Sure, if someone can tell me the necessary Kconfig magic
> > > for that. I'm not aware of any way to force something being
> > > a module only, I guess there is some trick to this, but nothing
> > > straight forward comes to mind.
> > 
> > I'm pretty sure:
> > 	depends on MODULES
> > does this, or something like that.
> 
> Ok, so I checked and all depends on MODULES does is check that module
> support is enabled, but the driver can still be built-in.
> 
> I googled for some solution but couldn't find any I'm afraid.

'depends on m' should do the trick.  Try that.

> Note FWIW that this problem already existed for some other symbols
> for some of the other rtl8* drivers in staging.

Yes I agree, which is why most of those drivers have that line in their
Kconfig file.  We should also add it to the one that this driver
conflicted with as well :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux