Re: [PATCH 1/1] staging: rtl8188eu: Macros with complex values should be enclosed in parentheses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 28, 2017 at 09:56:19PM +0100, Alfonso Lima Astor wrote:
> Fix coding style issue
> 
> Signed-off-by: Alfonso Lima Astor <alfonsolimaastor@xxxxxxxxx>
> ---
>  drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl.h b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> index a6b1c85..0c022a5 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> @@ -59,10 +59,10 @@
>  #define OID_MP_SEG4		0xFF011100
>  
>  #define DEBUG_OID(dbg, str)						\
> -	if ((!dbg)) {							\
> +	(if ((!dbg)) {							\
>  		RT_TRACE(_module_rtl871x_ioctl_c_, _drv_info_,		\
>  			 ("%s(%d): %s", __func__, __line__, str));	\
> -	}
> +	})

Your change doesn't do what you think it does :(

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux