Re: [PATCH 0/3] staging: ks7010: refactor tx_device_task()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 26, 2017 at 07:45:12PM +1100, Tobin C. Harding wrote:
> Function tx_device_task() is a candidate for refactoring. Checkpatch
> emits a number of warnings/checks for this function.
> 
> Patch 01 inverts if statement conditional and reduces the level of
> nesting.
> 
> Patch 02 renames rc -> ret, fixes function call and checkpatch WARNING.
> 
> Patch 03 fixes function argument alignment, and checkpatch CHECK.
> 
> Code is untested. Patch set applies and builds on x86_64 and PowerPC.

I count 35+ patches from you for the same driver within 2 days.  What
order am I supposed to apply these patches in?  Please resend them all
as a single patch series, so I have a chance to get it right.

And you can wait until I apply a series before sending another one,
otherwise we can easily get out of sync :(

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux