On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > Code uses identifiers retval, ret, and rc all for function return > > values. It would be more readable if the whole driver used a single > > identifier for this task. Lets use 'rc' since it is the shortest. > > > > Change retval -> rc > > Ick, retval is much more readable, please use that. > Or "ret" is probably the most common. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel