On Wed, Mar 15, 2017 at 09:48:55AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 09:48:14AM +0800, Greg Kroah-Hartman wrote:
> > On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> > > Bug introduced in commit 7676b72 by Tobin C. Harding.
> > >
> > > Remove equals sign from comparison, fixing off by one error.
> > >
> > > Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> >
> > In the future, when you fix something, it's nice to add a tag saying so
> > in this format:
> > Fixes: 7676b72428e8 ("staging: ks7010: move comparison to right hand side")
> >
> > You can generate the string by doing:
> > git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" 7676b72
> >
> > I'll add it for this one.
>
> Also, it's good to give credit to the person who found the bug:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Thank you, this is clearly stated in
Documentation/process/submitting-patches.rst since the bug was
reported on a mailing list. My mistake.
Got it now.
thanks,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
