Re: [PATCH] staging: ks7010: fix off by one error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 15, 2017 at 09:48:14AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> > Bug introduced in commit 7676b72 by Tobin C. Harding.
> > 
> > Remove equals sign from comparison, fixing off by one error.
> > 
> > Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> 
> In the future, when you fix something, it's nice to add a tag saying so
> in this format:
> Fixes: 7676b72428e8 ("staging: ks7010: move comparison to right hand side")
> 
> You can generate the string by doing:
> 	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" 7676b72

Righto, got it.

thanks,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux